Code Improvements: empty method check, merge adjacent IF's

src/main/java/net/spy/memcached/MemcachedConnection.java

@@ -456,7 +456,9 @@ public void handleIO() throws IOException {
    * called very often under heavy workloads, so it should not perform extensive
    * tasks in the same thread.</p>
    */
-  protected void handleWokenUpSelector() { }
+  protected void handleWokenUpSelector() {
+	  throw new UnsupportedOperationException();
+  }
 
   /**
    * Helper method for {@link #handleIO()} to encapsulate everything that

src/main/java/net/spy/memcached/TapClient.java

@@ -173,6 +173,7 @@ public Operation newOp(final MemcachedNode n,
         Operation op =  conn.getOpFactory().tapCustom(id, message,
             new TapOperation.Callback() {
             public void receivedStatus(OperationStatus status) {
+            	throw new UnsupportedOperationException();
             }
             public void gotData(ResponseMessage tapMessage) {
               rqueue.add(tapMessage);
@@ -217,6 +218,7 @@ public Operation newOp(final MemcachedNode n,
         Operation op =  conn.getOpFactory().tapDump(id,
             new TapOperation.Callback() {
             public void receivedStatus(OperationStatus status) {
+            	throw new UnsupportedOperationException();
             }
             public void gotData(ResponseMessage tapMessage) {
               rqueue.add(tapMessage);

src/main/java/net/spy/memcached/auth/AuthThread.java

@@ -208,11 +208,9 @@ public void complete() {
 
       // Get the new status to inspect it.
       priorStatus = foundStatus.get();
-      if (priorStatus != null) {
-        if (!priorStatus.isSuccess()) {
+      if (priorStatus != null && !priorStatus.isSuccess()) {
           getLogger().warn("Authentication failed to " + node.getSocketAddress()
             + ", Status: " + priorStatus);
-        }
       }
     }
 

src/main/java/net/spy/memcached/compat/log/AbstractLogger.java

@@ -54,10 +54,8 @@ public String getName() {
    */
   public Throwable getThrowable(Object[] args) {
     Throwable rv = null;
-    if (args.length > 0) {
-      if (args[args.length - 1] instanceof Throwable) {
+    if (args.length > 0 && args[args.length - 1] instanceof Throwable) {
         rv = (Throwable) args[args.length - 1];
-      }
     }
     return rv;
   }

src/main/java/net/spy/memcached/compat/log/SunLogger.java

@@ -106,15 +106,13 @@ public void log(Level level, Object message, Throwable e) {
     StackTraceElement logRequestor = null;
     String alclass = AbstractLogger.class.getName();
     for (int i = 0; i < ste.length && logRequestor == null; i++) {
-      if (ste[i].getClassName().equals(alclass)) {
-        // Make sure there's another stack frame.
-        if (i + 1 < ste.length) {
-          logRequestor = ste[i + 1];
-          if (logRequestor.getClassName().equals(alclass)) {
-            logRequestor = null;
-          } // Also AbstractLogger
-        } // Found something that wasn't abstract logger
-      } // check for abstract logger
+      // Make sure classes are equals and there's another stack frame.
+      if (ste[i].getClassName().equals(alclass) && i + 1 < ste.length) {
+        logRequestor = ste[i + 1];
+        if (logRequestor.getClassName().equals(alclass)) {
+          logRequestor = null;
+        } // Also AbstractLogger
+      } // check for abstract logger and found something that wasn't abstract logger
     }
 
     // See if we could figure out who was doing the original logging,