Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign of PlaybackManager #305

Merged
merged 16 commits into from
Dec 23, 2023
Merged

Redesign of PlaybackManager #305

merged 16 commits into from
Dec 23, 2023

Conversation

dweymouth
Copy link
Owner

This PR also contains the start of the Jukebox player backend, but should be merged to main now even though Jukebox is not complete, since it unblocks #11 and #33, and also the ability to add support for the OpenSubsonic transcodeOffset.

  • defined new simplified Player interface to allow for multiple player backends
  • PlaybackManager serves as an intermediary between user playback commands and the actual Player, for all operations
  • LoopMode logic now resides entirely in PlaybackManager
  • Queue is managed entirely by PlaybackManager, the player is only given the current track and next track (for gapless)

@dweymouth
Refactor pt. 1: move MPV player to own package and extract some types
55f9461
@dweymouth
fix non-Mac build
bd4db95
@dweymouth
Refactor pt. 2: route player transport controls+callbacks through Pla…
1665281 
…ybackManager
@dweymouth
add interface to decouple MPV player from PlaybackManager
df6c53a
@dweymouth
don't assume MPV player in now playing page
bcf95ba
@dweymouth
rework settings dialog to be aware of different player types
f8f8a3a
@dweymouth
start of JukeboxPlayer backend
1e466e4
@dweymouth
some simplification of PlaybackManager
4c3d638
@dweymouth
start of new simplified player interface
0cd58cb
@dweymouth
Beginning of reworked PlaybackManager - PARTIAL
d9eca8d
@dweymouth
move LoopMode
de6ba5c
@dweymouth
handle LoopMode logic, plus some reorganization
cf41795
@dweymouth
remove extra replaygain set
d089151
@dweymouth
when changing loop mode, only call player.SetNext if needed
cfb8739
@dweymouth
implement new logic for RemoveTracksFromQueue
91951eb
@dweymouth
remove unused PlaylistPos from player status
85bfa73
@dweymouth dweymouth merged commit 10feaad into main Dec 23, 2023
4 checks passed
@dweymouth dweymouth deleted the feature/jukebox branch July 18, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dweymouth