Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add developer_name to appstream data file #324

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

anarcat
Copy link
Contributor

@anarcat anarcat commented Jan 30, 2024

It seems this is necessary in Flatpaks now. I have a build that failed with:

flatpak run --command=flatpak-builder-lint org.flatpak.Builder --exceptions repo repo
 in dir /srv/buildbot/worker/build-x86_64-1/build (timeout 1200 secs)
 watching logfiles {}
 argv: b'flatpak run --command=flatpak-builder-lint org.flatpak.Builder --exceptions repo repo'
 using PTY: False
{
    "errors": [
        "appstream-missing-developer-name"
    ],
    "warnings": [
        "appstream-summary-too-long",
        "appstream-screenshot-missing-caption"
    ]
}
Please consult the documentation at https://docs.flathub.org/docs/for-app-authors/linter
program finished with exit code 1
elapsedTime=54.274905

... interestingly, that is marked as "warning" in the above documentation:

https://docs.flathub.org/docs/for-app-authors/linter/#appstream-missing-developer-name

... but is reported as an error now. Even worse, the tag is deprecated:

https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer_name

I tried to fix it by vendoring this fixed version in the flatpak, we'll see how that goes:

flathub/io.github.dweymouth.supersonic#62 (comment)

It seems this is necessary in Flatpaks now. I have a build that failed with:

```
flatpak run --command=flatpak-builder-lint org.flatpak.Builder --exceptions repo repo
 in dir /srv/buildbot/worker/build-x86_64-1/build (timeout 1200 secs)
 watching logfiles {}
 argv: b'flatpak run --command=flatpak-builder-lint org.flatpak.Builder --exceptions repo repo'
 using PTY: False
{
    "errors": [
        "appstream-missing-developer-name"
    ],
    "warnings": [
        "appstream-summary-too-long",
        "appstream-screenshot-missing-caption"
    ]
}
Please consult the documentation at https://docs.flathub.org/docs/for-app-authors/linter
program finished with exit code 1
elapsedTime=54.274905
```

... interestingly, that is marked as "warning" in the above
documentation:

https://docs.flathub.org/docs/for-app-authors/linter/#appstream-missing-developer-name

... but is reported as an error now. Even worse, the tag is
deprecated:

https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer_name

I tried to fix it by vendoring this fixed version in the flatpak,
we'll see how that goes:

flathub/io.github.dweymouth.supersonic#62 (comment)
@anarcat
Copy link
Contributor Author

anarcat commented Jan 30, 2024

don't merge until we get confirmation this is fixed in the flatpak, in flathub/io.github.dweymouth.supersonic#62 (comment)

@anarcat
Copy link
Contributor Author

anarcat commented Jan 30, 2024

looks like that passed, so this is ready to go. filed flathub-infra/flatpak-builder-lint#273 which has some explanations on the change.

@anarcat anarcat changed the title draft: add developer_name to appstream data file add developer_name to appstream data file Jan 30, 2024
@anarcat
Copy link
Contributor Author

anarcat commented Jan 30, 2024

@dweymouth i think this can be merged, at your convenience. of course you might want to tweak the name as you see fit...

@dweymouth dweymouth merged commit 5db80c7 into dweymouth:main Jan 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants