Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Share option for artists, albums, and tracks #336

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

adamantike
Copy link
Contributor

@adamantike adamantike commented Feb 27, 2024

This feature is only available on the Subsonic media provider. Using a Jellyfin server will make Supersonic hide the "Share" option.

  • Artists: Option available in grid view and in Artist view.
  • Albums: Option available in grid view and in Album view.
  • Tracks: Option available in tracklist, when a single track is selected.

Closes #303

ui/controller/controller.go Outdated Show resolved Hide resolved
Copy link
Owner

@dweymouth dweymouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good. Just a few more things

ui/browsing/artistpage.go Outdated Show resolved Hide resolved
ui/browsing/albumpage.go Outdated Show resolved Hide resolved
ui/widgets/tracklist.go Outdated Show resolved Hide resolved
This feature is only available on the Subsonic media provider. Using a
Jellyfin server will make Supersonic hide the "Share" option.

* Artists: Option available in grid view and in Artist view.
* Albums: Option available in grid view and in Album view.
* Tracks: Option available in tracklist, when a single track is selected.
@adamantike adamantike force-pushed the feat/add-share-option branch from 88d1a91 to a6fefc9 Compare March 4, 2024 00:01
Copy link
Owner

@dweymouth dweymouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@dweymouth dweymouth merged commit ea1b2f3 into dweymouth:main Mar 4, 2024
3 checks passed
@adamantike adamantike deleted the feat/add-share-option branch March 4, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "Create sharing link" option for tracks and albums
2 participants