-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve 'Add to playlists' dialog #382
chore: Improve 'Add to playlists' dialog #382
Conversation
Could we show all the playlists initially instead of an empty list? Note that this behavior would be different from the Quick Search dialog so it would probably need to be handled specially in the Add to playlist dialog implementation |
Yes, I can add a list with all the playlists and then filter by the search text |
c290915
to
1b53695
Compare
I overrode the
I'm not sure if this implementation is correct or if there is a better way to do it. |
@@ -179,4 +179,5 @@ type SearchResult struct { | |||
|
|||
// Unset for ContentTypes Artist, Playlist, and Genre | |||
ArtistName string | |||
Query string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure about adding Query to the SearchResult model, since that isn't really part of the search result per se. Instead, maybe the searchdialog can expose the query through another function call (SearchDialog.QueryText()?)
ArtistName: playlist.Name, | ||
}) | ||
} | ||
skipDuplicatesCheck := widget.NewCheck("Skip duplicates", func(checked bool) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can probably use NewCheckWithData here so that the state of the checkbox is automatically kept in sync with the sp.SkipDuplicates
bool
I'm going to merge this into a feature branch to test and tweak a bit before going to |
84d4208
into
dweymouth:improve-playlist-dialog
Fixes #344