Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsplash #7 #16

Closed
wants to merge 3 commits into from
Closed

Unsplash #7 #16

wants to merge 3 commits into from

Conversation

ndrean
Copy link
Collaborator

@ndrean ndrean commented Nov 15, 2023

Take a look: #7

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (4ce7a19) 100.00% compared to head (5fbcb00) 74.41%.

❗ Current head 5fbcb00 differs from pull request most recent head 369061d. Consider uploading reports for the commit 369061d to get more accurate results

Files Patch % Lines
lib/app_web/live/page_live.ex 57.69% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main      #16       +/-   ##
============================================
- Coverage   100.00%   74.41%   -25.59%     
============================================
  Files            2        2               
  Lines           28       43       +15     
============================================
+ Hits            28       32        +4     
- Misses           0       11       +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndrean ndrean closed this Nov 15, 2023
@ndrean
Copy link
Collaborator Author

ndrean commented Nov 15, 2023

Remove phx-disconnected warning when remove live_flash that appears twice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant