GRPC streaming move lock above send orderbook updates (#1707)

dydxprotocol · Jun 18, 2024 · a8619a7 · a8619a7
1 parent 357206b
commit a8619a7
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/protocol/streaming/grpc/grpc_streaming_manager.go b/protocol/streaming/grpc/grpc_streaming_manager.go
@@ -122,6 +122,9 @@ func (sm *GrpcStreamingManagerImpl) SendOrderbookUpdates(
 		updatesByClobPairId[clobPairId] = v1updates
 	}
 
+	sm.Lock()
+	defer sm.Unlock()
+
 	updatesBySubscriptionId := make(map[uint32][]clobtypes.StreamUpdate)
 	for id, subscription := range sm.orderbookSubscriptions {
 		// Consolidate orderbook updates into a single `StreamUpdate`.
@@ -185,6 +188,9 @@ func (sm *GrpcStreamingManagerImpl) SendOrderbookFillUpdates(
 		updatesByClobPairId[clobPairId] = append(updatesByClobPairId[clobPairId], streamUpdate)
 	}
 
+	sm.Lock()
+	defer sm.Unlock()
+
 	updatesBySubscriptionId := make(map[uint32][]clobtypes.StreamUpdate)
 	for id, subscription := range sm.orderbookSubscriptions {
 		streamUpdatesForSubscription := make([]clobtypes.StreamUpdate, 0)
@@ -215,9 +221,6 @@ func (sm *GrpcStreamingManagerImpl) sendStreamUpdate(
 		1,
 	)
 
-	sm.Lock()
-	defer sm.Unlock()
-
 	// Send updates to subscribers.
 	idsToRemove := make([]uint32, 0)
 	for id, subscription := range sm.orderbookSubscriptions {