Skip to content

Commit

Permalink
Stop passing in app PreBlocker to slinky VE handler (#1491) (#1492)
Browse files Browse the repository at this point in the history
(cherry picked from commit 2494557)

Co-authored-by: roy-dydx <[email protected]>
  • Loading branch information
mergify[bot] and roy-dydx authored May 10, 2024
1 parent eee8f67 commit e249026
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion protocol/app/app.go
Original file line number Diff line number Diff line change
Expand Up @@ -1541,7 +1541,15 @@ func (app *App) initOracle(pricesTxDecoder process.UpdateMarketPriceTxDecoder) {
compression.NewDefaultVoteExtensionCodec(),
compression.NewZLibCompressor(),
),
app.PreBlocker,
// We are not using the slinky PreBlocker, so there is no need to pass in PreBlocker here for
// VE handler to work properly.
// Currently the clob PreBlocker assumes that it will only be called during the normal ABCI
// PreBlocker step. Passing in the app PreBlocker here will break that assumption by causing
// the clob PreBlocker to be called unexpectedly. This to leads improperly initialized clob state
// which results in the next block being committed incorrectly.
func(_ sdk.Context, _ *abci.RequestFinalizeBlock) (*sdk.ResponsePreBlock, error) {
return nil, nil
},
app.oracleMetrics,
)

Expand Down

0 comments on commit e249026

Please sign in to comment.