stop properly

dydxprotocol · Jun 6, 2024 · edb122c · edb122c
1 parent 7974fe1
commit edb122c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 2 deletions.
diff --git a/protocol/app/app.go b/protocol/app/app.go
@@ -458,6 +458,9 @@ func New(
 			if app.SlinkyClient != nil {
 				app.SlinkyClient.Stop()
 			}
+			if app.GrpcStreamingManager != nil {
+				app.GrpcStreamingManager.Stop()
+			}
 			return nil
 		},
 	)

diff --git a/protocol/streaming/grpc/grpc_streaming_manager.go b/protocol/streaming/grpc/grpc_streaming_manager.go
@@ -72,7 +72,6 @@ func NewGrpcStreamingManager(
 		for {
 			select {
 			case <-grpcStreamingManager.ticker.C:
-				// fix this with values
 				grpcStreamingManager.FlushStreamUpdates()
 			case <-grpcStreamingManager.done:
 				return

diff --git a/protocol/streaming/grpc/noop_streaming_manager.go b/protocol/streaming/grpc/noop_streaming_manager.go
@@ -46,3 +46,6 @@ func (sm *NoopGrpcStreamingManager) SendOrderbookFillUpdates(
 func (sm *NoopGrpcStreamingManager) GetUninitializedClobPairIds() []uint32 {
 	return []uint32{}
 }
+
+func (sm *NoopGrpcStreamingManager) Stop() {
+}
diff --git a/protocol/streaming/grpc/types/manager.go b/protocol/streaming/grpc/types/manager.go
@@ -7,7 +7,7 @@ import (
 
 type GrpcStreamingManager interface {
 	Enabled() bool
-
+	Stop()
 	// L3+ Orderbook updates.
 	Subscribe(
 		req clobtypes.StreamOrderbookUpdatesRequest,