Fix uncaught postgres error #2635
Conversation
|
Warning Rate limit exceeded@roy-dydx has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 13 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughThe changes in this pull request focus on enhancing the error handling of the Changes
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
indexer/services/comlink/src/lib/compliance-and-geo-check.ts (1)
53-57: Consider cold start reliability improvements.While using a read replica is good for performance, it might cause issues during cold starts due to replication lag. Consider:
- Adding a fallback to the primary database if the read replica query fails
- Setting an appropriate transaction isolation level to ensure consistent reads
Example implementation:
const updatedStatus: ComplianceStatusFromDatabase[] = await ComplianceStatusTable.findAll( { address: [address] }, [], - { readReplica: true }, + { + readReplica: true, + fallbackToMaster: true, + isolationLevel: 'READ COMMITTED' + }, );
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
indexer/services/comlink/src/lib/compliance-and-geo-check.ts(2 hunks)
🔇 Additional comments (2)
indexer/services/comlink/src/lib/compliance-and-geo-check.ts (2)
17-20: LGTM: Import changes align with new error handling.
The addition of handleInternalServerError import is appropriate for the new error handling implementation.
52-80: LGTM: Proper error handling implementation.
The try-catch block with handleInternalServerError appropriately handles potential PostgreSQL errors, preventing uncaught exceptions.
roy-dydx
force-pushed
the
roy/uncaughtpostgres
branch
from
4e18bf9 to
0799e5d
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
indexer/services/comlink/src/lib/helpers.ts (2)
Line range hint
85-106: LGTM! The error handling implementation looks robust.The exported
handleInternalServerErrorfunction provides comprehensive error handling with:
- Development-specific console logging
- Structured error logging with context (location, message, stack trace, request params)
- Standardized 500 response
However, consider adding request headers to the logged information for better debugging capabilities.
logger.error({ at, message, error, stacktrace: error.stack, params: JSON.stringify(req.params), query: JSON.stringify(req.query), + headers: JSON.stringify(req.headers), });
Line range hint
85-106: Consider adding postgres-specific error handling.Given that this PR aims to fix uncaught postgres errors, consider enhancing the error handling to specifically identify and handle postgres errors (e.g., connection issues, constraint violations) with appropriate status codes and messages.
export function handleInternalServerError( at: string, message: string, error: Error, req: express.Request, res: express.Response, ): express.Response { + // Check for postgres-specific errors + if (error.name === 'SequelizeConnectionError') { + logger.error({ + at, + message: 'Database connection error', + error, + stacktrace: error.stack, + }); + return res.status(503).json({ + errors: [{ + msg: 'Database temporarily unavailable', + }], + }); + } + if (config.isDevelopment()) { // eslint-disable-next-line no-console console.error(error); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (2)
indexer/services/comlink/src/lib/compliance-and-geo-check.ts(2 hunks)indexer/services/comlink/src/lib/helpers.ts(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- indexer/services/comlink/src/lib/compliance-and-geo-check.ts
🔇 Additional comments (1)
indexer/services/comlink/src/lib/helpers.ts (1)
Line range hint 85-106: Security review: Error handling implementation follows best practices.
The error handling correctly:
- Logs detailed error information internally
- Returns sanitized error messages to clients
- Only exposes additional details in development mode
roy-dydx
force-pushed
the
roy/uncaughtpostgres
branch
from
0799e5d to
c14037f
Compare
|
@Mergifyio backport release/indexer/v7.x |
✅ Backports have been created
|
|
https://github.com/Mergifyio backport release/indexer/v8.x |
✅ Backports have been created
|
(cherry picked from commit 1b03acb)
(cherry picked from commit 1b03acb)
Co-authored-by: roy-dydx <[email protected]>
Co-authored-by: roy-dydx <[email protected]>
Changelist
Test Plan
[Describe how this PR was tested (if applicable)]
Author/Reviewer Checklist
state-breakinglabel.indexer-postgres-breakinglabel.PrepareProposalorProcessProposal, manually add the labelproposal-breaking.feature:[feature-name].backport/[branch-name].refactor,chore,bug.Summary by CodeRabbit
Bug Fixes
Chores