Skip to content

Commit

Permalink
Remove references to private repos (#41)
Browse files Browse the repository at this point in the history
  • Loading branch information
Christopher-Li authored Oct 16, 2023
1 parent a112ed7 commit 904d5fa
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 9 deletions.
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,15 +20,15 @@ Install the terraform cli using tfenv. We currently use version 1.3.2 of terrafo
### How to test local infra changes against "dev" env

This workspace is configured using [The CLI-driven Run Workflow](https://www.terraform.io/cloud-docs/run/cli). You should feel empowered to plan and apply at your discretion to this workspace with no approval or code review required. This is to help facilitate your own testing before opening a PR to `v4-terraform`. In order to plan and apply in this workspace, follow these steps:
This workspace is configured using [The CLI-driven Run Workflow](https://www.terraform.io/cloud-docs/run/cli).

1. Install `terraform` if you haven't done so already following the instructions [here](https://www.terraform.io/downloads).
1. Running `terraform --version` should output a version `>= v1.3.2`.
1. Login to Terraform Cloud via `terraform login`. You will be asked to create a token and provide it to the CLI.
1. `cd` into the relevant folder, for example `/validators`, `/indexer`, `/faucet`, or `/loadtesters`.
1. `cd` into the relevant folder, for example `/indexer`, `/metrics_ingestor`, or `/indexer_dashboards`.
1. Initialize terraform if you haven't done so already with `terraform init`.
1. Run `terraform workspace select validators-dev` to select the dev workspace for `validators`. You can also run `terraform workspace list` to see available workspaces.
1. Once you've selected the `validators-dev` workspace, feel free to run `terraform plan` and `terraform apply` to trigger your runs. Note that these runs will still take place remotely in Terraform Cloud, but the output will be streamed to your machine.
1. Run `terraform workspace select indexer-dev` to select the dev workspace for `validators`. You can also run `terraform workspace list` to see available workspaces.
1. Once you've selected the `indexer-dev` workspace, feel free to run `terraform plan` and `terraform apply` to trigger your runs. Note that these runs will still take place remotely in Terraform Cloud, but the output will be streamed to your machine.

### How to apply changes to infra to "staging" env

Expand Down
2 changes: 0 additions & 2 deletions indexer/ecs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ resource "aws_ecs_service" "main" {
lifecycle {
# We ignore changes to the `task-definition` of the ECS service as the specific deployed Task Definition
# is part of our service deploy process. Applying Terraform should not trigger a new deploy of services.
# Deployment is handled with [orb](https://github.com/dydxprotocol/orb).
ignore_changes = [
task_definition
]
Expand Down Expand Up @@ -94,7 +93,6 @@ resource "aws_ecs_task_definition" "main" {
name = "${var.environment}-${var.indexers[var.region].name}-${each.key}-service-container"
# Note: Task Definitions created through Terraform are never deployed, but we expect this to be a valid URL
# in the container image's ECR repository (even if the tag does not exist).
# For more information, see here: https://github.com/dydxprotocol/orb/blob/main/lambda/jobs/deploy/README.md
image = "${aws_ecr_repository.main[each.key].repository_url}:created-by-terraform-with-no-image"

essential = true
Expand Down
3 changes: 0 additions & 3 deletions modules/validator/ecs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ resource "aws_ecs_service" "main" {
lifecycle {
# We ignore changes to the `task-definition` of the ECS service as the specific deployed Task Definition
# is part of our service deploy process. Applying Terraform should not trigger a new deploy of services.
# Deployment is handled with [orb](https://github.com/dydxprotocol/orb).
ignore_changes = [
task_definition
]
Expand Down Expand Up @@ -78,11 +77,9 @@ resource "aws_ecs_task_definition" "main" {
[
{
# Note the suffix "service-container" here is relevant as it's how we denote the main container
# that is deployed via `orb`.
name = "${var.environment}-${var.name}-service-container"
# Note: Task Definitions created through Terraform are never deployed, but we expect this to be a valid URL
# in the container image's ECR repository (even if the tag does not exist).
# For more information, see here: https://github.com/dydxprotocol/orb/blob/main/lambda/jobs/deploy/README.md
image = "${var.ecr_repository_url}:created-by-terraform-with-no-image"

environment = flatten(
Expand Down

0 comments on commit 904d5fa

Please sign in to comment.