Refactor amplitude API gateway #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pswies
requested review from
jiajames,
vincentwschau,
Christopher-Li and
lucas-dydx
as code owners
pswies
force-pushed
the
refactor-amplitude-api-gw
branch
from
4f7ff74 to
748b768
Compare
This was referenced Feb 8, 2024
pswies
force-pushed
the
refactor-amplitude-api-gw
branch
from
60770b5 to
08709fb
Compare
- Move from modules to main dir, as this is an end-deployment, not a module - Rename resources to match Terraform style standards (each type of resources has only one instance, so naming the instances duplicates information; therefore they can be named this, default, main or so) - Parametrize AWS region - Break down into sub-files - Add Terraform output item to show the effective invoke_url - Rename dir api_gateway to amplitude_api_gateway to express its specificity
pswies
force-pushed
the
refactor-amplitude-api-gw
branch
from
08709fb to
a3b55f3
Compare
jiajames
approved these changes
Feb 12, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this,default,mainor so)invoke_urlapi_gatewaytoamplitude_api_gatewayto express its specificity