[CT-578] Add aws secret for db password #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dydxwill
requested review from
jiajames,
vincentwschau and
Christopher-Li
as code owners
dydxwill
changed the title
indexer/locals.tf
Outdated
| @@ -19,7 +19,7 @@ locals { | |||
| } | |||
|
|
|||
| service_secret_ids = { | |||
| for name in local.service_names : name => "${var.environment}-${name}-secrets" | |||
| for name in local.service_names : name => "${var.aws_db_secret_id}" | |||
There was a problem hiding this comment.
Was this change made so that a deployer could determine what secret to create in secrets manager before deploying?
There's other secrets that exist today, this could break deployments that had diff. secret ids right?
There was a problem hiding this comment.
Good point, addressed.
There was a problem hiding this comment.
Right now, there's existing dev-vulcan-secrets/dev-ender-secrets/etc. We'll need to add db_password into these secrets manually. Env variables are encrypted & passed into lambdas.
vincentwschau
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested in dev