Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mode switch in profile view #335

Merged
merged 15 commits into from
Jan 15, 2025
Merged

Mode switch in profile view #335

merged 15 commits into from
Jan 15, 2025

Conversation

ruixhuang
Copy link
Contributor

Simulator Screenshot - iPhone 16 Pro - 2025-01-15 at 14 12 44


Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

@ruixhuang ruixhuang marked this pull request as ready for review January 15, 2025 22:13
Base automatically changed from feature/sui_8 to develop January 15, 2025 22:24
@ruixhuang
Merge branch 'develop' into feature/sui_9
863cdf7 
# Conflicts:
#	dydx/dydxPresenters/dydxPresenters.xcodeproj/project.pbxproj
#	dydx/dydxViews/dydxViews.xcodeproj/project.pbxproj
tyleroooo
tyleroooo approved these changes Jan 15, 2025
View reviewed changes
Copy link

@tyleroooo tyleroooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LETS GO

@ruixhuang ruixhuang merged commit 69209c2 into develop Jan 15, 2025
5 checks passed
@ruixhuang ruixhuang deleted the feature/sui_9 branch January 15, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyleroooo tyleroooo tyleroooo approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruixhuang @tyleroooo