Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate search view #336

Merged
merged 16 commits into from
Jan 15, 2025
Merged

Separate search view #336

merged 16 commits into from
Jan 15, 2025

Conversation

ruixhuang
Copy link
Contributor

The embedded search still feels better, but this is what design/product wants. We can change it back if needed.

Simulator Screenshot - iPhone 16 Pro - 2025-01-15 at 14 15 11


Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

@ruixhuang ruixhuang marked this pull request as ready for review January 15, 2025 22:17
Base automatically changed from feature/sui_9 to develop January 15, 2025 23:18
# Conflicts:
#	dydx/dydxPresenters/dydxPresenters.xcodeproj/project.pbxproj
#	dydx/dydxPresenters/dydxPresenters/_v4/SimpleUI/Markets/components/dydxSimpleUIMarketListViewPresenter.swift
#	dydx/dydxPresenters/dydxPresenters/_v4/SimpleUI/Markets/components/dydxSimpleUIPositionListViewPresenter.swift
#	dydx/dydxPresenters/dydxPresenters/_v4/SimpleUI/Markets/dydxSimpleUIMarketsViewBuilder.swift
#	dydx/dydxViews/dydxViews.xcodeproj/project.pbxproj
#	dydx/dydxViews/dydxViews/_v4/SimpleUI/Markets/components/dydxSimpleUIMarketListView.swift
#	dydx/dydxViews/dydxViews/_v4/SimpleUI/Markets/components/dydxSimpleUIMarketView.swift
#	dydx/dydxViews/dydxViews/_v4/SimpleUI/Markets/dydxSimpleUIMarketsView.swift
@ruixhuang ruixhuang merged commit 7816492 into develop Jan 15, 2025
5 checks passed
@ruixhuang ruixhuang deleted the feature/sui_10 branch January 15, 2025 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants