Mike/trcl 3314 trading rewards profile card #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TRCL-3314 Trading Rewards Profile Card
As a user I would like to see a trading rewards summary card on my profile screen which, when tapped, navigates to a trading rewards details screen |
mike-dydx
force-pushed
the
mike/trcl-3314-trading-rewards-profile-card
branch
from
d5eb865 to
d8fad93
Compare
mike-dydx
commented
Dec 4, 2023
Comment on lines
-40
to
-52
| HStack { | ||
| Text(DataLocalizer.localize(path: "APP.GENERAL.FEES")) | ||
| .themeFont(fontSize: .small) | ||
| Spacer() | ||
| PlatformIconViewModel(type: .system(name: "chevron.right"), | ||
| size: CGSize(width: 10, height: 10), | ||
| templateColor: .textSecondary) | ||
| .createView(parentStyle: style) | ||
| Text(self.takerFeeRate ?? "-") | ||
| .themeFont(fontType: .text, fontSize: .small) | ||
| .themeColor(foreground: .textPrimary) | ||
| .leftAligned() | ||
| } | ||
| .padding() | ||
|
|
||
| DividerModel() | ||
| .createView(parentStyle: style) |
There was a problem hiding this comment.
this code was refactored into a shared base class dydxTitledCardView
ruixhuang
approved these changes
Dec 4, 2023
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
* refactor fees card with reusable title card view * refactor history view to use dydxTitledCardView * change name for profile "rewards" -> "balances" card * do not wrap "reduce-only" text * add rewards card to profile landing screen * add comment * reorder cards * clean up * set up presenter view model links
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* refactor fees card with reusable title card view * refactor history view to use dydxTitledCardView * change name for profile "rewards" -> "balances" card * do not wrap "reduce-only" text * add rewards card to profile landing screen * add comment * reorder cards * clean up * set up presenter view model links
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* refactor fees card with reusable title card view * refactor history view to use dydxTitledCardView * change name for profile "rewards" -> "balances" card * do not wrap "reduce-only" text * add rewards card to profile landing screen * add comment * reorder cards * clean up * set up presenter view model links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Linear Ticket: TRCL-3314 : Trading Rewards Profile Card
Figma Design: https://www.figma.com/file/fMQodZKzn9B5aZTN5G0fLJ/dYdX-%E2%80%BA-Desktop?type=design&node-id=19900-54665&mode=design&t=OifmOQjr8CYRVNL0-4
Description / Intuition
dydxTitledCardViewbase componentdydxTitledCardViewdydxProfileRewardsViewfor displaying rewardsNote, abacus is not yet ready with rewards data, so the rewards card is commented out for now
Before/After Screenshots or Videos
Type of Change