Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRCL-3318 : Trading Rewards Details Screen Help Card #38

Merged

Conversation

mike-dydx
Copy link
Contributor

@mike-dydx mike-dydx commented Dec 5, 2023

Links (dYdX Internal Use Only)

Linear Ticket: TRCL-3318 : Trading Rewards Details Screen Help Card

Figma Design: https://www.figma.com/file/fMQodZKzn9B5aZTN5G0fLJ/dYdX-%E2%80%BA-Desktop?type=design&node-id=19925-60293&mode=design&t=NT9QtnjbvijzqYvP-4


Description / Intuition

  • adds an faq/help card to the trading rewards screen
  • row items on the card are expandable/collapsable

Before/After Screenshots or Videos

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2023-12-06.at.15.24.00.mp4

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

@mike-dydx mike-dydx requested review from johnqh and ruixhuang December 6, 2023 20:25
@mike-dydx mike-dydx self-assigned this Dec 6, 2023
@mike-dydx mike-dydx marked this pull request as ready for review December 6, 2023 20:25
@johnqh johnqh merged commit 021dcac into main Dec 6, 2023
2 checks passed
@johnqh johnqh deleted the mike/trcl-3318-trading-rewards-details-screen-help-card branch December 6, 2023 20:59
mike-dydx added a commit that referenced this pull request Aug 20, 2024
* show help card in trading rewards

* add learn more action to card

* add padding

* update font size

* add comment

* fix expand/collapse behavior
mike-dydx added a commit that referenced this pull request Aug 21, 2024
* show help card in trading rewards

* add learn more action to card

* add padding

* update font size

* add comment

* fix expand/collapse behavior
mike-dydx added a commit that referenced this pull request Aug 21, 2024
* show help card in trading rewards

* add learn more action to card

* add padding

* update font size

* add comment

* fix expand/collapse behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants