Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRCL-3464 : Remove trade network from standard settings #53

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

mike-dydx
Copy link
Contributor

@mike-dydx mike-dydx commented Jan 11, 2024

Links (dYdX Internal Use Only)

Linear Ticket: TRCL-3464 : Remove trade network from standard settings


Description / Intuition

  • removes trading network selector from default settings (still available in debug settings)
  • renames settings file from settings_loggedout to just settings

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

Copy link

linear bot commented Jan 11, 2024

@mike-dydx mike-dydx requested review from johnqh and ruixhuang January 11, 2024 14:46
…d settings

Revert "clean up settings files, remove trading network selector from standard settings"

This reverts commit ca25616.

clean up settings files, remove trading network selector from standard settings
@mike-dydx mike-dydx force-pushed the mike/clean-up-settings branch from 481639c to ed6e273 Compare January 11, 2024 14:51
@johnqh johnqh merged commit a4d5b61 into main Jan 11, 2024
1 of 2 checks passed
@johnqh johnqh deleted the mike/clean-up-settings branch January 11, 2024 15:33
mike-dydx added a commit that referenced this pull request Aug 20, 2024
mike-dydx added a commit that referenced this pull request Aug 21, 2024
mike-dydx added a commit that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants