Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaned up order details #71

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Cleaned up order details #71

merged 2 commits into from
Jan 25, 2024

Conversation

johnqh
Copy link
Contributor

@johnqh johnqh commented Jan 25, 2024

Links (dYdX Internal Use Only)

Linear Ticket: https://linear.app/dydx/issue/TRCL-3502/[jan23-2024-ios-testing]-limit-order-automatically-cancelled


Description / Intuition

Haven't reproduced the ticket. Changed order details so if it is canceled, we will see a reason.


After Screenshots or Videos

Never mind the cancel reason string, it doesn't make sense. Captured in TRCL-3524

Simulator Screenshot - iPhone 15 - 2024-01-25 at 10 09 03


Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

Copy link

linear bot commented Jan 25, 2024

TRCL-3502 [Jan23-2024 iOS Testing] limit order automatically cancelled

actual behavior:
open a limit order, it gets canceled immediately

expected behavior:*
open a limit order, should stay open until filled or expiry

reproduction steps:

screenshots/recordings:

RPReplay_Final1706039487.mov

@johnqh johnqh requested review from mike-dydx and ruixhuang January 25, 2024 18:40
@ruixhuang ruixhuang merged commit eb269da into main Jan 25, 2024
2 checks passed
@ruixhuang ruixhuang deleted the feature/TRCL-3502-order-details branch January 25, 2024 19:03
mike-dydx pushed a commit that referenced this pull request Aug 20, 2024
* Cleaned up order details

* Localize cancelReason
mike-dydx pushed a commit that referenced this pull request Aug 21, 2024
* Cleaned up order details

* Localize cancelReason
mike-dydx pushed a commit that referenced this pull request Aug 21, 2024
* Cleaned up order details

* Localize cancelReason
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants