Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fixes #443

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Misc fixes #443

merged 3 commits into from
Nov 27, 2024

Conversation

devkral
Copy link
Contributor

@devkral devkral commented Nov 27, 2024 •
edited
Loading

Checklist

  • The code has 100% test coverage.
  • The documentation was properly created or updated (if applicable) following the correct guidelines and appropriate language.
  • I branched out from the latest main or is a sub-branch.

Summary or description

Changes:

  • fix test which fails when executed alone
  • add no_leak test
  • Encoder inherit from the EncoderProtocol instead of the lilya Encoder

@devkral
Changes:
68dcd3a 
- fix test
- speedier method get_esmerald_encoders which just returns esmerald
  encoders
- Encoder inherit from the EncoderProtocol instead of the lilya Encoder,
  this prevents confusion of apply_structure

FIXME: get_esmerald_encoders cannot be used in signature
@devkral
revert "speedup", just fix bugs
2236223
@devkral devkral changed the title Add speedier function get_esmerald_encoders Misc fixes Nov 27, 2024
@tarsil tarsil merged commit 2953870 into main Nov 27, 2024
9 checks passed
@tarsil tarsil deleted the devkral/enhancement/esmerald_speedup branch November 27, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarsil tarsil tarsil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devkral @tarsil