Fix crashes in tests due to a reused registry #476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Summary or description
With edgy 0.25.0 a check was introduced so models don't get automatically replaced when a new model with the same name and
the same registry was specified.
Esmerald uses for tests a central settings object with a cached registry on it. Multiple test files define same named models on the same registry. Guess what? Silent replacements, a source of pain and workarounds and now it finally just crashed on the try.
This PR cleans the silent replacements up. It creates a local Registry for all edgy model defining tests except for cli which uses the edgy_registry now exclusively.