Better error handling for ill-formatted messages #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, on android, if there was a single ill-formatted message, we used to abort the entire sync. Now, we only skip that message. Currently, all skipped messages are deleted at the end of the sync. We were originally going to store skipped messages in a separate error database. But it turns out that on iOS, we check validity at insert time, and invalid messages are not stored in the usercache at all, which means that they are effectively discarded. We need to decide our error handling policy. Until we do this, we discard on both iOS (at insert time) and on android (at upload time). We have created an error database to store the data, but are not using it pending decision. The issue is being tracked in: e-mission#7
shankari
added a commit
that referenced
this pull request
Feb 29, 2016
Better error handling for ill-formatted messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, on android, if there was a single ill-formatted message, we used
to abort the entire sync. Now, we only skip that message. Currently, all
skipped messages are deleted at the end of the sync.
We were originally going to store skipped messages in a separate error
database. But it turns out that on iOS, we check validity at insert time, and
invalid messages are not stored in the usercache at all, which means that they
are effectively discarded.
We need to decide our error handling policy. Until we do this, we discard on
both iOS (at insert time) and on android (at upload time). We have created an
error database to store the data, but are not using it pending decision.
The issue is being tracked in:
#7