New battery optimization request permissions popup. #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pop up to ignore battery optimizations.
shankari
approved these changes
Sep 29, 2023
There was a problem hiding this comment.
Nice clean PR! Note that the issue is not fully done. Once I have merged this PR, I will create a new release on e-mission-data-collection. You will then need to submit a PR on e-mission-phone to bump up the version number in package.cordovabuild.json so that the new version of the plugin is actually used in the UI
| @@ -93,6 +93,8 @@ void requestPermission() { | |||
| String.format("After iterating over all entries in %s shouldShowRequest = %s", currPermissions, shouldShowRequestRationaleBefore)); | |||
| if (openAppSettings) { | |||
| SensorControlForegroundDelegate.this.openAppSettingsPage(cordovaCallback, permissionStatusConstant); | |||
| } else if (permissionStatusConstant == SensorControlConstants.IGNORE_BATTERY_OPTIMIZATIONS) { | |||
There was a problem hiding this comment.
Neat! I like the reuse of the existing permissions mechanism. In a future cleanup, we may want to also change openAppSettings from a separate boolean to using a separate constant and clean up that interface...
|
New release created at https://github.com/e-mission/e-mission-data-collection/releases/tag/v1.8.0 |
Abby-Wheelis
pushed a commit
to JGreenlee/e-mission-phone
that referenced
this pull request
Oct 6, 2023
As a result of e-mission/e-mission-data-collection#209, we now have a popup for this permission, so all the user needs to do is allow it! Translate PR to follow with this small change to en.json
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated the
REQUEST_IGNORE_BATTERY_OPTIMIZATIONSpermission so that users will just get a pop up now asking them to turn off battery optimization instead of having to go dig through their settings as per issue 980.This is also an extension of this closed PR. I created this new PR to clean up the commit history as the previous PR was really hard to understand.