🧹 Profile cleanup #1028
Merged
🧹 Profile cleanup #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 11, 2023 09:52
This setTime action is broken, so we must remove it from the notifications We can restore this is a few weeks after we migrate to React routing
to remedy a lag in the displayed notification time, set the notification settings to refresh when the uiConfig changes, this allows the settings to refresh after it is properly set, and prevents the initially blank reminder time I was seeing
added 2 commits
September 11, 2023 10:12
lingering code pending update to Samsung situation -- removed since it isn't used at all, and will add what is needed later
After reports of the instructions being confusing on Android 13 - update text to specify more closely what needs to be changed on 13 in particular This app (https://www.followmee.com/FAQ.aspx?t=androidunusedapp#) had an instructions page that explained the process for different Android OS well
added 3 commits
September 11, 2023 11:32
move appVersion to be more visible to users also caught and fixed an error where appVersion was held as an object and not a string
we should not allow users to download data from prior to the beginning of their study The month was setting as 1 in advance of the config, so I adjusted manually with the "-1"
the styling on the opcode modal was not consistent with the other modals, I remedied this by passing the style in from ProfileSettings as a parameter
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging Migration of Profile Logic #1009, there are a few cleanup changes to be addressed before the changes can go into production. These include:
Other changes may become necessary as we test recent changes on staging