Refactor User Stats Tests to Pipeline-Dependent and Independent Updates #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ats. Independent User Stats updates last call ts while Dependent User Stats updates range and trips. The two test cases should handle both scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates our tests for user statistics to reflect the recent refactor that separates pipeline-dependent statistics (such as trip counts and pipeline range) from pipeline-independent statistics (such as last_call_ts). Simplified the comments for brevity and to match the new changes.
Changes
Pipeline-Dependent Stats:
The test now verifies that after running the intake pipeline via etc.runIntakePipeline, the user profile is updated with:
Pipeline-Independent Stats:
Testing
python -m unittest emission/tests/analysisTests/intakeTests/TestUserStat.py