-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coverage action #856
Coverage action #856
Conversation
…on-server into coverage_action
I'm missing something with how external PRs work with the comment action. It should be able to do it (py-cov-action/python-coverage-comment-action-v2-example#2) and I thought I had set it up correctly (https://github.com/ewjoachim/python-coverage-comment-action-example/blob/master/.github/workflows/coverage.yml) but it isn't working. |
Given the number of changes, I assume that I can squash merge this. |
hm, by external PR, I assume you mean a PR from an external fork @aGuttman Couple of thoughts there:
So add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good.
Let's get this merged!
Setting verbose didn't produce a comment, but the message left in the run when attempting to post the comment is longer. Maybe helpful to read through it. |
Yeah the comment says:
|
The workflow run step is, I believe, what happens in the coverage.yml file. The documentation doesn't actually explain it. |
Adds new GitHub action that automatically runs all tests and generates a coverage report on new pull requests. Coverage percentage shown as a badge in the README, and a comment detailing coverage of new lines added is generated on the pull request. Comment feature requires that repo wiki be turned on and have at least one page.
Makes use of two marketplace actions.
Badge:
https://github.com/marketplace/actions/coverage-py-badge
Comment:
https://github.com/marketplace/actions/python-coverage-comment
(This comment action would be able to provide the badge as well, but there seems to be a problem with it: py-cov-action/python-coverage-comment-action#15)
Changes:
relative_files = True
to work with actions. Omits coverage of test files and emission/net/api/bottle.py, which artificially inflate and deflate the coverage percentage, respectfully.