Ft/show prompt of update #357
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit 738df53.
☁️ Nx Cloud last updated this comment at |
chrismclarke
requested changes
Jan 30, 2025
There was a problem hiding this comment.
@Pamella014
Thanks for making the changes to isolate the code in a service, I think overall is looking in a good state. See a few minor comments inline that it would be good to tidy up, and after that I will try to get a testing version deployed so we can confirm if behaves as expected
apps/picsa-tools/extension-content/src/app/pages/home/extension-home.component.ts
Outdated
Show resolved
Hide resolved
|
Thank you @chrismclarke for the feedback. I will review and make the necessary changes. Should i create a new pr once i am done? |
|
@chrismclarke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created an app update service that can be accessed anywhere in the app and then i imported it into the main extension app entry component.
closes #348