Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaption of std type functions #317

Merged
merged 22 commits into from
Feb 8, 2022
Merged

Conversation

dlohmeier
Copy link
Collaborator

Related to Issue #312

  • new functions copied from pandapower
  • moved standard types from net.std_type to net.std_types
  • moved StdType class to other module
  • renamed some function args

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #317 (9686e94) into develop (bee09b3) will increase coverage by 0.13%.
The diff coverage is 88.08%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #317      +/-   ##
===========================================
+ Coverage    90.52%   90.66%   +0.13%     
===========================================
  Files           76       76              
  Lines         4147     4198      +51     
===========================================
+ Hits          3754     3806      +52     
+ Misses         393      392       -1     
Impacted Files Coverage Δ
pandapipes/properties/properties_toolbox.py 98.55% <ø> (ø)
pandapipes/std_types/std_type_class.py 82.43% <82.43%> (ø)
pandapipes/io/io_utils.py 87.05% <85.71%> (-0.29%) ⬇️
pandapipes/std_types/std_types.py 89.88% <89.88%> (ø)
pandapipes/__init__.py 100.00% <100.00%> (ø)
pandapipes/component_models/pump_component.py 98.78% <100.00%> (ø)
pandapipes/create.py 99.12% <100.00%> (ø)
pandapipes/io/convert_format.py 97.22% <100.00%> (+0.55%) ⬆️
pandapipes/io/file_io.py 82.14% <100.00%> (ø)
pandapipes/std_types/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bee09b3...9686e94. Read the comment docs.

@dlohmeier
Copy link
Collaborator Author

Todos left:

  • Change all std types such that they only contain relevant information for the network. The Pipe.csv table can be helpful and left the way it is, but when loading it to net.std_types, it should be converted rather than during the create-function.
  • Pump std_types: Structure seems a little confusing and in the components, the calls are not vectorized.

Copy link
Collaborator

@jkisse jkisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

dlohmeier and others added 4 commits February 1, 2022 13:24
…dapt_std_types

� Conflicts:
�	compressor_component.py
�	pandapipes/__init__.py
�	pandapipes/std_types/std_type.py
�	pandapipes/std_types/std_type_toolbox.py
@dlohmeier dlohmeier merged commit 40ac6fc into e2nIEE:develop Feb 8, 2022
@dlohmeier dlohmeier deleted the adapt_std_types branch March 4, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants