add friction model "Hofer" #683
Conversation
jkisse
changed the title
|
Looks interesting. I just thought that the transition area is relevant for different models. Maybe we should think about how to correct equations for laminar / turbulent flow. I think there is an issue on this topic and this implementation could be a nice approach. |
|
Thanks @dlohmeier! (analogously for np.abs and np.power) |
|
As far as I can recall, numba was good at exactly this: identify numpy code within jit-decorated functions and compile them correctly. I always found it more readable and wrt. timings I remember that I found no difference or a slight advantage of the numpy ufuncs over native code. It might have changed with newer numba versions. |
| (:math:`Re < \underline{Re}`) and :math:`\lambda_H` is used for high Reynolds numbers (:math:`Re > \overline{Re}`). | ||
| In the transition area :math:`\underline{Re} \leq Re \leq \overline{Re}`, :math:`\lambda_H` is interpolated linearly. | ||
| By default, the boundaries of this transition area are set to :math:`\underline{Re}=2000` and :math:`\overline{Re}=3000`. | ||
| Note that the derivative used for Hofer is the same as for Prandtl-Colebrook. |
There was a problem hiding this comment.
Is the PC-derivative indeed applicable in this case or is it an approximation, since Hofer is just an explicit form of Prandtl-Colebrook?
There was a problem hiding this comment.
Not sure - I found it acceptable, also because of the quite complicated derivative of the Hofer formula. Apparently it is working ; )
Maybe the convergence behaviour could be strengthened if a separate "Hofer-derivative" is implemented, but I find it sufficient so far.
… default max_iter_hyd
|
We found out that max_iter has been renamed rather silently a year ago, thus I'd like to use this PR to add a warning for those who still use it. When calculating large transmissions grids, we often need more than 10 iterations. Therefore, I'd appreciate it if we could set it to 30 by default. It shouldn't have any significant effects on the runtime. |
Increasing the default number of iterations is indeed necessary in quite some calculation scenarios for us, so I would welcome that change. Wrt. the max_iter kwarg, I am a little surprised, since I thought we really intended to make this change backwards compatible. A warning is indeed appropriate then. |
The friction factor "Hofer" is introduced. It is an explicit implementation of Colebrook, used by some established Gas Grid Simulation tools.
Please refer to the added paragraph in the docs for more details.