Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parameter fuse_bus_column to merge_internal_net_and_equivalent_external_net() #2163

Merged
merged 4 commits into from
Nov 8, 2023

Conversation

SteffenMeinecke
Copy link
Member

No description provided.

ZhengLiu1119
ZhengLiu1119 previously approved these changes Nov 6, 2023
@ZhengLiu1119
Copy link
Member

ZhengLiu1119 commented Nov 6, 2023

The removed input parameter eq_type should also be removed in the equivalent tutorial.
The error regarding pandamodels tutorials is probably caused by the version of julia, see ReactionMechanismGenerator/RMG-Py@b49e19a

could you please try and edit the environment file? maybe github_test_action.yml?

@SteffenMeinecke
Copy link
Member Author

The error regarding pandamodels tutorials is probably caused by the version of julia, see ReactionMechanismGenerator/RMG-Py@b49e19a

could you please try and edit the environment file? maybe github_test_action.yml?

Dear @ZhengLiu1119, thanks for replying. In that link, julia version 1.9.0 is excepted. However, in the current pandpower action yml julia version 1.9.3 is installed.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (d8e128e) 79.55% compared to head (8925301) 79.53%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2163      +/-   ##
===========================================
- Coverage    79.55%   79.53%   -0.02%     
===========================================
  Files          255      255              
  Lines        27798    27807       +9     
===========================================
+ Hits         22115    22117       +2     
- Misses        5683     5690       +7     
Files Coverage Δ
pandapower/toolbox/grid_modification.py 90.52% <ø> (ø)
pandapower/grid_equivalents/rei_generation.py 91.20% <60.00%> (-0.45%) ⬇️
pandapower/grid_equivalents/get_equivalent.py 90.59% <61.53%> (-2.30%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZhengLiu1119 ZhengLiu1119 merged commit 05f5304 into e2nIEE:develop Nov 8, 2023
17 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants