Resolving simple bug [bug] Incorrect Pluralization in plural_s Function (Simple) #2180 #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2181 +/- ##
========================================
Coverage 79.65% 79.65%
========================================
Files 255 255
Lines 27795 27795
========================================
Hits 22139 22139
Misses 5656 5656 ☔ View full report in Codecov by Sentry. |
SteffenMeinecke
approved these changes
Nov 29, 2023
|
@rfcordeiro thanks for providing this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses the bug identified in the plural_s function within the pandapower project. The issue occurs when attempting to pluralize a word based on a given number. The current implementation incorrectly returns an empty string when the number is greater than 1, indicating the plural form. The fix ensures that the function now correctly returns an empty string for numbers equal to or less than 1, and "s" for numbers greater than 1.
Changes Made:
Modified the plural_s function to correctly handle pluralization based on the input number.
Issue opened number #2180