Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unbalanced powerflow with out of service ext grids #2227

Merged
merged 8 commits into from
Jun 13, 2024

Conversation

jkupka
Copy link
Collaborator

@jkupka jkupka commented Feb 29, 2024

Solves a mismatch of arrays during zero impedance addition of ext grids if at least one ext grid is out of service

@jkupka jkupka requested a review from rbolgaryn February 29, 2024 13:00
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.66%. Comparing base (f2794c6) to head (4613282).
Report is 106 commits behind head on develop.

Current head 4613282 differs from pull request most recent head 14c156e

Please upload reports for the commit 14c156e to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #2227       +/-   ##
============================================
+ Coverage    62.30%   79.66%   +17.36%     
============================================
  Files          255      255               
  Lines        28062    27840      -222     
============================================
+ Hits         17483    22178     +4695     
+ Misses       10579     5662     -4917     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jkupka jkupka requested a review from dlohmeier March 6, 2024 08:28
@rbolgaryn
Copy link
Member

This one was merged: fix unbalanced powerflow with out ouf service ext grids #2184

Is this PR still relevant?

@vogt31337
Copy link
Contributor

@jkupka @dlohmeier still relevant?

@jkupka
Copy link
Collaborator Author

jkupka commented Mar 28, 2024

yes, it's still relevant as it solves a different issue than #2184

Copy link
Member

@rbolgaryn rbolgaryn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the comment from Daniel and add information to CHANGELOG.
Please also write a test that fails with the current pandapower and passes because with this pull request.

@rbolgaryn
Copy link
Member

@jkupka please address the change request

@jkupka jkupka requested a review from rbolgaryn May 24, 2024 12:56
@SteffenMeinecke
Copy link
Member

for some reason, I cannot push to this branch with opened PR or open a PR to that branch, but I can confirm that the conflicts are regarding the changelog only.

@jkupka
Copy link
Collaborator Author

jkupka commented Jun 12, 2024

The merge conflict was resolved. Failing tests seem to have nothing to do with the changes in this pull request

@SteffenMeinecke SteffenMeinecke self-requested a review June 13, 2024 06:16
@SteffenMeinecke
Copy link
Member

The merge conflict was resolved. Failing tests seem to have nothing to do with the changes in this pull request

For some reason, I still cannot merge. Maybe git rebase is needed or something else. I don't know. Alternatively, I open another PR with the same fix.

@dlohmeier dlohmeier requested review from rbolgaryn and removed request for rbolgaryn June 13, 2024 09:12
@dlohmeier
Copy link
Collaborator

@rbolgaryn can you approve? Seems like it is not possible to merge without your approval.

@SteffenMeinecke SteffenMeinecke merged commit 41a6eab into e2nIEE:develop Jun 13, 2024
15 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants