-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix unbalanced powerflow with out of service ext grids #2227
fix unbalanced powerflow with out of service ext grids #2227
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2227 +/- ##
============================================
+ Coverage 62.30% 79.66% +17.36%
============================================
Files 255 255
Lines 28062 27840 -222
============================================
+ Hits 17483 22178 +4695
+ Misses 10579 5662 -4917 ☔ View full report in Codecov by Sentry. |
This one was merged: fix unbalanced powerflow with out ouf service ext grids #2184 Is this PR still relevant? |
@jkupka @dlohmeier still relevant? |
yes, it's still relevant as it solves a different issue than #2184 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please address the comment from Daniel and add information to CHANGELOG.
Please also write a test that fails with the current pandapower and passes because with this pull request.
@jkupka please address the change request |
…ower into fix/unbalanced_powerflow Conflicts: CHANGELOG.rst
for some reason, I cannot push to this branch with opened PR or open a PR to that branch, but I can confirm that the conflicts are regarding the changelog only. |
The merge conflict was resolved. Failing tests seem to have nothing to do with the changes in this pull request |
For some reason, I still cannot merge. Maybe |
@rbolgaryn can you approve? Seems like it is not possible to merge without your approval. |
Solves a mismatch of arrays during zero impedance addition of ext grids if at least one ext grid is out of service