Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add binding screens #39

Merged
merged 6 commits into from
Mar 2, 2022
Merged

Add binding screens #39

merged 6 commits into from
Mar 2, 2022

Conversation

Del-S
Copy link
Contributor

@Del-S Del-S commented Jun 28, 2021

Added:

  • Multiple binding screens and fragments.
  • Keyboard view and Fragment extensions.
  • Dependency for material and core ktx.

@Del-S Del-S added the enhancement New feature or request label Jun 28, 2021
@Del-S Del-S added this to the 0.9.0 milestone Jun 28, 2021
@Del-S Del-S requested review from vsouhrada, smidf and PistaToth June 28, 2021 13:12
@Del-S Del-S force-pushed the feature/add_binding_screens branch from 558c021 to 2e78e03 Compare June 30, 2021 14:24
@Del-S Del-S modified the milestones: 0.9.0, 0.10.0 Jul 19, 2021
@smidf smidf changed the title Added binding screens. Add binding screens Aug 30, 2021
smidf
smidf requested changes Aug 31, 2021
View reviewed changes
kaal-presentation/src/main/kotlin/cz/eman/kaal/presentation/fragment/FragmentExtensions.kt Outdated Show resolved Hide resolved
kaal-presentation/src/main/kotlin/cz/eman/kaal/presentation/view/ViewExtensions.kt Outdated Show resolved Hide resolved
...n/src/main/kotlin/cz/eman/kaal/presentation/fragment/KaalBindingBottomSheetDialogFragment.kt Outdated Show resolved Hide resolved
...presentation/src/main/kotlin/cz/eman/kaal/presentation/fragment/KaalBindingDialogFragment.kt Outdated Show resolved Hide resolved
kaal-presentation/src/main/kotlin/cz/eman/kaal/presentation/fragment/KaalBindingScreen.kt Show resolved Hide resolved
...resentation/src/main/kotlin/cz/eman/kaal/presentation/fragment/KaalToolbarBindingFragment.kt Outdated Show resolved Hide resolved
...resentation/src/main/kotlin/cz/eman/kaal/presentation/fragment/KaalToolbarBindingFragment.kt Outdated Show resolved Hide resolved
...resentation/src/main/kotlin/cz/eman/kaal/presentation/fragment/KaalToolbarBindingFragment.kt Outdated Show resolved Hide resolved
...resentation/src/main/kotlin/cz/eman/kaal/presentation/fragment/KaalToolbarBindingFragment.kt Outdated Show resolved Hide resolved
...resentation/src/main/kotlin/cz/eman/kaal/presentation/fragment/KaalToolbarBindingFragment.kt Outdated Show resolved Hide resolved
@smidf smidf self-assigned this Aug 31, 2021
@Del-S Del-S mentioned this pull request Oct 18, 2021
Open
Del-S pushed a commit to Del-S/kaal that referenced this pull request Oct 18, 2021
🎨 Review for eManPrague#39
c009d4b
Del-S pushed a commit to Del-S/kaal that referenced this pull request Oct 18, 2021
🎨 View non-null for eManPrague#39
2e0f3b2
@Del-S Del-S mentioned this pull request Oct 18, 2021
Open
Del-S pushed a commit to Del-S/kaal that referenced this pull request Mar 2, 2022
🎨 Review for eManPrague#39
4ecc5bc
Del-S pushed a commit to Del-S/kaal that referenced this pull request Mar 2, 2022
🎨 View non-null for eManPrague#39
aa43011
@Del-S Del-S force-pushed the feature/add_binding_screens branch from fb51206 to a1e7024 Compare March 2, 2022 11:13
@Del-S Del-S force-pushed the feature/add_binding_screens branch from a1e7024 to ee8f467 Compare March 2, 2022 14:24
smidf
smidf approved these changes Mar 2, 2022
View reviewed changes
...resentation/src/main/kotlin/cz/eman/kaal/presentation/fragment/KaalToolbarBindingFragment.kt
* @see 0.9.0
*/
@Suppress("MemberVisibilityCanBePrivate")
open class KaalToolbarBindingFragment<B : ViewDataBinding>(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#53

...resentation/src/main/kotlin/cz/eman/kaal/presentation/fragment/KaalToolbarBindingFragment.kt Show resolved Hide resolved
@smidf smidf merged commit 313d5cd into eManPrague:master Mar 2, 2022
@Del-S Del-S deleted the feature/add_binding_screens branch March 7, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@musilto8 musilto8 musilto8 left review comments

@smidf smidf smidf approved these changes

@vsouhrada vsouhrada Awaiting requested review from vsouhrada

@PistaToth PistaToth Awaiting requested review from PistaToth

Assignees

@smidf smidf

@PistaToth PistaToth

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Del-S @smidf @musilto8 @PistaToth