Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2023] Compatibility with pandas 2.0, and Read the Docs #18

Merged
merged 16 commits into from
Apr 10, 2023
Merged

Conversation

amotl
Copy link
Member

@amotl amotl commented Apr 10, 2023

Maintenance

  • Add compatibility with pandas 2.0. It has been released recently. 1
  • Remove compatibility details with Python 2.

Documentation

  • Give the code examples more love. Outline a snippet within the README, and add them to the test suite. This improves educating people how to use phenodata as a library, see Using phenodata as a library #3.
  • Add configuration to publish the documentation to Read the Docs.
  • Add CITATION.cff file. 23
  • Significantly rework README, and improve documentation across the board.
  • Make the "forecast" feature less prominent, because it offers only a naive approach.
  • Add proselint.

Footnotes

  1. https://phofl.github.io/pandas-20.html

  2. https://the-turing-way.netlify.app/communication/citable/citable-cff.html

  3. https://citation-file-format.github.io/

@amotl amotl force-pushed the documentation branch 2 times, most recently from 2d4b0dc to 58b99c6 Compare April 10, 2023 03:01
@amotl amotl changed the title [2023] Documentation improvements, Read the Docs [2023] Read the Docs and compatibility with pandas 2 Apr 10, 2023
@amotl amotl force-pushed the documentation branch 2 times, most recently from c2e1ddd to 73b3efa Compare April 10, 2023 03:11
@amotl amotl changed the title [2023] Read the Docs and compatibility with pandas 2 [2023] Compatibility with pandas 2, and Read the Docs Apr 10, 2023
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.61 🎉

Comparison is base (0696811) 89.68% compared to head (fdbdc14) 90.30%.

❗ Current head fdbdc14 differs from pull request most recent head 0dbb411. Consider uploading reports for the commit 0dbb411 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #18      +/-   ##
==========================================
+ Coverage   89.68%   90.30%   +0.61%     
==========================================
  Files           6        8       +2     
  Lines         601      629      +28     
==========================================
+ Hits          539      568      +29     
+ Misses         62       61       -1     
Flag Coverage Δ
unittests 90.30% <100.00%> (+0.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
phenodata/command.py 80.80% <ø> (ø)
examples/observations.py 100.00% <100.00%> (ø)
examples/stations.py 100.00% <100.00%> (ø)
phenodata/dwd/cdc.py 92.00% <100.00%> (-0.16%) ⬇️
phenodata/dwd/pheno.py 91.69% <100.00%> (+0.36%) ⬆️
phenodata/ftp.py 91.80% <100.00%> (-0.07%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@amotl amotl changed the title [2023] Compatibility with pandas 2, and Read the Docs [2023] Compatibility with pandas 2.0, and Read the Docs Apr 10, 2023
@amotl amotl marked this pull request as ready for review April 10, 2023 23:41
@amotl amotl merged commit d59b25d into main Apr 10, 2023
@amotl amotl deleted the documentation branch April 10, 2023 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant