Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python3 migration #489

Closed
wants to merge 11 commits into from
Closed

Python3 migration #489

wants to merge 11 commits into from

Conversation

PyvesB
Copy link
Collaborator

@PyvesB PyvesB commented Jul 17, 2019

This pull request closes #488.

Each fix was broken down in a separate commit with a (hopefully) informative message, however, we could squash all commits when merging to master.

@nigelmegitt
Copy link
Collaborator

Thank you @PyvesB for your great work on this.

I see that there's an issue with travis CI to do with encrypted environment variables so I will check it manually. I also expect a BDD failure matching #490 to occur, since I haven't found the fix for that yet.

One other thing, I will create a release candidate branch and make that the target of this pull request rather than heading directly to master.

@nigelmegitt nigelmegitt changed the base branch from master to release/3.0 July 17, 2019 10:53
@nigelmegitt
Copy link
Collaborator

nigelmegitt commented Jul 17, 2019

I tested this manually with Python 3.7.4 and get 8 test failures, all in ebu_tt_live/twisted/test/test_twisted_websocket.py except for one that relates to #490. @PyvesB I think perhaps you've resolved this somehow?

@PyvesB
Copy link
Collaborator Author

PyvesB commented Jul 17, 2019

These failures aren't dependent on Python versions, but rather the version of the Autobahn dependency. The 1.18.x and 1.19.x versions no longer allow the test suite you mentioned to run successfully.

@nigelmegitt nigelmegitt changed the base branch from release/3.0 to master July 18, 2019 08:29
@nigelmegitt nigelmegitt changed the base branch from master to release/3.0 July 18, 2019 08:30
@nigelmegitt nigelmegitt mentioned this pull request Aug 7, 2019
@nigelmegitt
Copy link
Collaborator

I note that this pull request has a problem that other pull requests from forks have, that the travis CI build cannot run because the source repo doesn't have the same credentials as the destination repo. I'm not sure what pattern fixes this, but the easiest practical thing is to merge this into a new branch in the ebu repo and pull request from that into release/3.0.

@nigelmegitt nigelmegitt mentioned this pull request Oct 10, 2019
@nigelmegitt
Copy link
Collaborator

Closing in favour of #512 which should have more success with the travis CI build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants