-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python3 migration #489
Python3 migration #489
Conversation
Thank you @PyvesB for your great work on this. I see that there's an issue with travis CI to do with encrypted environment variables so I will check it manually. I also expect a BDD failure matching #490 to occur, since I haven't found the fix for that yet. One other thing, I will create a release candidate branch and make that the target of this pull request rather than heading directly to master. |
These failures aren't dependent on Python versions, but rather the version of the Autobahn dependency. The 1.18.x and 1.19.x versions no longer allow the test suite you mentioned to run successfully. |
I note that this pull request has a problem that other pull requests from forks have, that the travis CI build cannot run because the source repo doesn't have the same credentials as the destination repo. I'm not sure what pattern fixes this, but the easiest practical thing is to merge this into a new branch in the ebu repo and pull request from that into |
Closing in favour of #512 which should have more success with the travis CI build. |
This pull request closes #488.
Each fix was broken down in a separate commit with a (hopefully) informative message, however, we could squash all commits when merging to master.