Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile saving bug #389

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Fix profile saving bug #389

merged 1 commit into from
Jun 2, 2024

Conversation

octogradiste
Copy link
Contributor

The problem was that we called the onSave callback (which starts a coroutine to save the profile) and didn't wait for it to finish before navigating to the map.

@octogradiste octogradiste added the bug Something isn't working label Jun 2, 2024
@octogradiste octogradiste added this to the Milestone 4 milestone Jun 2, 2024
@octogradiste octogradiste self-assigned this Jun 2, 2024
@octogradiste octogradiste marked this pull request as ready for review June 2, 2024 14:35
@srsingh04 srsingh04 self-requested a review June 2, 2024 14:37
Copy link
Contributor

@srsingh04 srsingh04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the bug!

The problem was that we called the onSave callback (which starts a coroutine to save the profile) and didn't wait for it to finish before navigating to the map.
@octogradiste octogradiste force-pushed the fix/profile-creation-saving branch from ddbf769 to dee5a0e Compare June 2, 2024 14:39
@octogradiste octogradiste enabled auto-merge (rebase) June 2, 2024 14:39
Copy link

sonarqubecloud bot commented Jun 2, 2024

@octogradiste octogradiste merged commit 9f01a86 into main Jun 2, 2024
2 checks passed
@octogradiste octogradiste deleted the fix/profile-creation-saving branch June 2, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done in sprint 10
Development

Successfully merging this pull request may close these issues.

2 participants