Issue 305 #394
Closed
Issue 305 #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Enri Ozuni <[email protected]>
Signed-off-by: Enri Ozuni <[email protected]>
|
@kruegers This PR is ready to be merged. |
kruegers
reviewed
May 5, 2020
| @@ -36,7 +36,7 @@ public static boolean verifyPWHash(char[] pwd, java.lang.String pwdhash) throws | |||
| byte[] res = null; | |||
| int keysize = 160; | |||
|
|
|||
| CrySLCodeGenerator.getInstance().includeClass("java.security.PBEKeySpec").addParameter(pwd, "password").addParameter(salt, "salt").addParameter(keysize, "keylength") | |||
| CrySLCodeGenerator.getInstance().includeClass("java.security.SecureRandom").addParameter(salt, "next").includeClass("java.security.PBEKeySpec").addParameter(pwd, "password").addParameter(salt, "salt").addParameter(keysize, "keylength") | |||
There was a problem hiding this comment.
This is incorrect, though. The verification must not randomize the hash, but take the one that is used for the creation of the hash (as defined in line 35).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a typo in the code generator template regarding the "Encode Password for Secure Storage" task, where the generated code produces insecure findings when analyzed with CogniCrypt SAST.
Fixes #305
Type of change
How Has This Been Tested?
This has been tested in inner Eclipse and produces the expected results.
Test Configuration:
Checklist: