Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove json-2.0.jar from dependencies #25294

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Conversation

11rx4f
Copy link
Contributor

@11rx4f 11rx4f commented Dec 19, 2024

Fix for: https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/15598

json-2.0.jar contains org.json package and json.js, but they are no longer necessary.

  • the org.json package has been replaced by jakarta.json
  • json.js implements parse and stringify methods, but JavaScript engine now provide a superior impl itself

Also, while it is difficult to cover all operations, I've confirmed that the admin console basically works without it.

so we can remove it.

json-2.0.jar also needs to be removed from woodstock, and I'll create a pull request as well.
(This fix alone allows GlassFish to run without json-2.0.jar, even without integrating the woodstock that has had json-2.0.jar removed.)

@dmatej dmatej added this to the 7.0.21 milestone Dec 19, 2024
@pzygielo pzygielo merged commit 2e10ed7 into eclipse-ee4j:master Dec 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants