Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Digital Twin Provider Tutorial #68

Merged
merged 22 commits into from
Nov 15, 2023
Merged

Add Digital Twin Provider Tutorial #68

merged 22 commits into from
Nov 15, 2023

Conversation

jorchiu
Copy link
Contributor

@jorchiu jorchiu commented Nov 10, 2023

This PR adds a tutorial for adding a digital twin provider.

Copy link
Contributor

github-actions bot commented Nov 10, 2023

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨

docs/tutorials/in_vehicle_model/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
samples/mixed/provider/src/main.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. Please review.

docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Show resolved Hide resolved
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional comments.

docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
devkelley
devkelley previously approved these changes Nov 14, 2023
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
samples/tutorial/consumer/src/main.rs Outdated Show resolved Hide resolved
samples/tutorial/provider/src/provider_impl.rs Outdated Show resolved Hide resolved
wilyle
wilyle previously approved these changes Nov 14, 2023
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments.

samples/interfaces/tutorial/digital_twin_provider.proto Outdated Show resolved Hide resolved
samples/tutorial/consumer/src/main.rs Show resolved Hide resolved
samples/tutorial/consumer/src/main.rs Outdated Show resolved Hide resolved
samples/tutorial/consumer/src/main.rs Show resolved Hide resolved
samples/tutorial/provider/src/provider_impl.rs Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
docs/tutorials/provider/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@jorchiu
Copy link
Contributor Author

jorchiu commented Nov 15, 2023

The markdown-link-check states that https://aka.ms/opensource/security/msrc and https://aka.ms/opensource/security/cvd are dead links. These links are valid.

@jorchiu jorchiu merged commit 6cb95ae into main Nov 15, 2023
12 of 13 checks passed
@jorchiu jorchiu deleted the jorchiu/tutorial_provider branch November 15, 2023 17:54
mobicatk pushed a commit to Mobica/EclipseSDV_ibeji that referenced this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants