Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ibeji Dockerfiles #81

Merged
merged 6 commits into from
Dec 7, 2023
Merged

Update Ibeji Dockerfiles #81

merged 6 commits into from
Dec 7, 2023

Conversation

devkelley
Copy link
Contributor

This PR does the following:

  • Removes 'containerize' feature: commit 1 (e2a4d10)
  • Add aarch64 target configuration: commit 1 (e2a4d10)
  • Update/Add Dockerfiles for arm64 and amd64. Dockerfiles are now more generic: commit 2 (26e106b)
  • Update container READMEs: commit 3 (2ab7bf4)

Copy link
Contributor

github-actions bot commented Dec 7, 2023

Alex Recommends Report

Alex recommends the following language changes, but Alex is a regular expression based algorithm, so take them with a grain of salt.

✨ 🚀 ✨ Nothing to Report ✨ 🚀 ✨

wilyle
wilyle previously approved these changes Dec 7, 2023
Dockerfile.arm64 Show resolved Hide resolved
container/README.md Outdated Show resolved Hide resolved
wilyle
wilyle previously approved these changes Dec 7, 2023
ashbeitz
ashbeitz previously approved these changes Dec 7, 2023
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@devkelley devkelley dismissed stale reviews from ashbeitz and wilyle via d5a97ab December 7, 2023 22:03
Copy link
Contributor

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@devkelley devkelley merged commit 3fbc1a5 into main Dec 7, 2023
13 checks passed
mobicatk pushed a commit to Mobica/EclipseSDV_ibeji that referenced this pull request Apr 24, 2024
* Remove Containerize feature and add aarch64 targets

* Updated Dockerfiles for amd64 and arm64

* Update README's to reflect container changes

* Fix link and linting

* make optional args more concise

* remove unused comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants