Ensure CompilationUnitResolver.accept(...) uses right module #2300
+3
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this change, addType was always performed against the unnamed module (and some new package bindings & types were created) while it should look up on the current context module.
What it does
Fix CompilationUnitResolver so it properly resolve packages from the visible modules
How to test
I plan to provide a unit test reproducing it in a near future. Basically start from the same structure as ModuleBuilderTests.testAutoModule3 , but instead of calling
getWorkingCopy("/mod.one/src/q/X.java", srcX, true)
, try calling ASTParser to generate the DOM CompilationUnit and check itsgetProblems()
.Author checklist