Remove custom ReferenceBinding.hashCode() #3584
Open
+29
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukzi
force-pushed
the
ReferenceBinding.hashCode()
branch
2 times, most recently
from
e5d7d96 to
1d29592
Compare
To avoid possible hash collisions. Instead of manipulating the existing key in a map remove exiting entry and put the updated entry. Use a HashMap instead of SimpleLookupTable. eclipse-jdt#3412
jukzi
force-pushed
the
ReferenceBinding.hashCode()
branch
from
1d29592 to
1592f16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid possible hash collisions.
Instead of manipulating the existing key in a map remove exiting entry and put the updated entry.
Use a HashMap instead of SimpleLookupTable.
#3412