Adding test cases for folding

[jakub-suliga]

I have added test cases to validate the current folding mechanism.

[jakub-suliga]

@fedejeanne @iloveeclipse Could you review this PR?

[danthe1st]

I assume you will need different tests for your folding of control structures PR (#1562).
Given that (and that I will also need to add test cases related to folding in my PR adding custom folding blocks via comments (#1825), I would suggest creating one test suite for folding tests that delegates to the different test classes for different purposes (for now just your FoldingTest).

For example, this could be

@Suite
@SelectClasses({
	FoldingTest.class,
	// to be added in the future - not for your PR, I am just including that for your understanding
	//ControlStructureFoldingTest.class,
	//CustomFoldingRegionTest.class
})
public class FoldingTestSuite {
}

It should then be possible to reference that test suite in JdtTextTestSuite.

Note: I am not experienced with JDT, I am just making a suggestion.

[fedejeanne]

Looks pretty good, I think it covers most of the existing cases today. I would add some more test cases though.

[jakub-suliga]

I assume you will need different tests for your folding of control structures PR (#1562). Given that (and that I will also need to add test cases related to folding in my PR adding custom folding blocks via comments (#1825), I would suggest creating one test suite for folding tests that delegates to the different test classes for different purposes (for now just your FoldingTest).

@fedejeanne @iloveeclipse What do you think of this? I’m capable of implementing it, but I don’t have enough experience to decide if this is the best way to structure the tests.

[jakub-suliga]

@jjohnstn Could you please review this code too? I have added the checks for the region values as you suggested in #1562. I will also add these checks in the other PR later. Additionally, could you let me know if the above proposal looks good?

[jjohnstn]

@jjohnstn Could you please review this code too? I have added the checks for the region values as you suggested in #1562. I will also add these checks in the other PR later. Additionally, could you let me know if the above proposal looks good?

Looks good. I will merge if the CodeQL check goes through or doesn't finish in the next few minutes.