Automate JLS selection toggles in AST view #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather then explicitly listing versions cycle through the AST supported versions and create for toggle for each of them. Mnemonics for these toggles are removed now but they have been broken already as there have been conflicts (8 and 18, 9 and 19, 10 and 20, 11 and 21, 12 and 22, 13 and 23) rendering mnemonics useless. This has the good side effect of removing the need to touch AST view for new Java version support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather then explicitly listing versions cycle through the AST supported versions and create for toggle for each of them.
Mnemonics for these toggles are removed now but they have been broken already as there have been conflicts (8 and 18, 9 and 19, 10 and 20, 11 and 21, 12 and 22, 13 and 23) rendering mnemonics useless. This has the good side effect of removing the need to touch AST view for new Java version support.