-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix workflows #3
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,7 +16,9 @@ jobs: | |
with: | ||
# required to grab the history of the PR | ||
fetch-depth: 0 | ||
- uses: actions/setup-python@v3 | ||
- uses: pre-commit/[email protected] | ||
- uses: actions/setup-python@v5 | ||
with: | ||
python-version: '3.10' | ||
- uses: pre-commit/[email protected] | ||
with: | ||
extra_args: --color=always --from-ref ${{ github.event.pull_request.base.sha }} --to-ref ${{ github.event.pull_request.head.sha }} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
# See https://pre-commit.com for more information | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We can discuss how useful it is to have pre-commit as we mainly have Rust files, but if we have it we need this file. It will at least check for trailing whitespaces in *.md, *.yaml and similar files. Cargo tools maybe anyway do similar tasks for Rust files? |
||
# See https://pre-commit.com/hooks.html for more hooks | ||
repos: | ||
- repo: https://github.com/pre-commit/pre-commit-hooks | ||
rev: v3.2.0 | ||
hooks: | ||
- id: trailing-whitespace | ||
exclude_types: ["dbc"] | ||
- id: end-of-file-fixer | ||
exclude_types: ["dbc", "json"] | ||
exclude: \.token$ | ||
- id: check-yaml | ||
- id: check-added-large-files |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
# Contributing to Eclipse Kuksa | ||
|
||
Thanks for your interest in this project. | ||
|
||
## Eclipse Contributor Agreement | ||
|
||
Before your code contribution can be accepted by the project team contributors must | ||
electronically sign the Eclipse Contributor Agreement (ECA). | ||
|
||
* http://www.eclipse.org/legal/ECA.php | ||
|
||
Commits that are provided by non-committers must have a Signed-off-by field in | ||
the footer indicating that the author is aware of the terms by which the | ||
contribution has been provided to the project. The non-committer must | ||
additionally have an Eclipse Foundation account and must have a signed Eclipse | ||
Contributor Agreement (ECA) on file. | ||
|
||
For more information, please see the Eclipse Committer Handbook: | ||
https://www.eclipse.org/projects/handbook/#resources-commit | ||
|
||
## Contact | ||
|
||
Contact the project developers via the project's "dev" list. | ||
|
||
* https://dev.eclipse.org/mailman/listinfo/kuksa-dev | ||
|
||
## Pre-commit set up | ||
This repository is set up to use [pre-commit](https://pre-commit.com/) hooks. | ||
Use `pip install pre-commit` to install pre-commit. | ||
After you clone the project, run `pre-commit install` to install pre-commit into your git hooks. | ||
Pre-commit will now run on every commit. | ||
Every time you clone a project using pre-commit running pre-commit install should always be the first thing you do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We get a warning "Node.js 16 actions are deprecated. " if using v3 (but it works).
If using v4 (to resolve warning) it seems we need to create a token and upload.
Could possibly be done similar to how we do for other secrets at https://github.com/eclipse-kuksa/.eclipsefdn/blob/main/otterdog/eclipse-kuksa.jsonnet#L29