Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading codecov dependency #31

Merged
merged 1 commit into from
May 14, 2024

Conversation

erikbosch
Copy link
Contributor

@erikbosch erikbosch commented May 13, 2024

Seems to be working. Well - upload does not work due to a limit for tokenless update, likely same problem as we often see for v3. Will do a retry tomorrow morning when it maybe is lower load as the Americans are sleeping.

It is MAYBE so that we could add a token to the fork, but we cannot expect that all forks have a suitable token, and it seems to imply that we enable codecov for that particular organization

error - 2024-05-13 14:46:53,425 -- Report creating failed: {"detail":"Tokenless has reached GitHub rate limit. Please upload using a token: https://docs.codecov.com/docs/adding-the-codecov-token. Expected available in 924 seconds."}

@SebastianSchildt
Copy link
Contributor

SebastianSchildt commented May 14, 2024

Ok, just saw the error, but let me summarise what we see here

  • For PRs like this the secret in our orga is not available, thus the Action tries "tokenless"
  • It may likely hit the rate limit, and print a message in logs, but the CI is still green (which I think it ok)
  • If we would merge something in main, of course CI runs in context ouf our orga, and thus Uplaod should work

If we want more regular suceeding upload (and leave a bit of bandwidth for outside contributors), we could add a similarly named token to the orga we mostly do PRs from, and it would to tokenized upload

Anyway, as I have seen the repo idle for a bit, I will try manually retriggering the run, to see what happens when it can upload

Maybe in the long run, there might be a way, where the PR only generated Codevov input file and saves it as artefact, and we have another workflow running on something like

on:
  workflow_run:
    workflows: ["CodeCov prep"]  
    types:
      - completed

But anyway, no idea that is working, more of long term idea (this would need somehow to identify the run in question, find the artefact AND give Codecov all necessary meta data, so maybe not even possible)

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.57%. Comparing base (e628c46) to head (0fa0eb8).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   48.61%   48.57%   -0.05%     
==========================================
  Files          31       31              
  Lines       10879    10866      -13     
==========================================
- Hits         5289     5278      -11     
+ Misses       5590     5588       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as expected

Just maybe we want to configure/fine-tune on what conditions this reports failure

@erikbosch
Copy link
Contributor Author

@SebastianSchildt - what we possibly should follow up is what is reported as "base". In the image below it uses a quite old version (17 commits!) , possibly because it was that long time ago we last had a successful upload for main.

image

@erikbosch erikbosch merged commit 82513ea into eclipse-kuksa:main May 14, 2024
22 of 23 checks passed
@erikbosch erikbosch mentioned this pull request May 14, 2024
@erikbosch erikbosch deleted the erik_codecov branch November 15, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants