Adding opentelemety as a feature "otel" #92
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikbosch
reviewed
Nov 1, 2024
databroker/src/open_telemetry.rs
Outdated
| .with_exporter( | ||
| opentelemetry_otlp::new_exporter() | ||
| .tonic() | ||
| .with_endpoint("http://localhost:4317"), |
There was a problem hiding this comment.
Is 4317 a standard port for this type of functionality?
There was a problem hiding this comment.
Yes, It's a standard port for Jaeger backend. As Jaeger backend can also run on other device, I have made the endpoint configurable through env variable in my latest commit.
erikbosch
requested review from
argerus,
SebastianSchildt,
rafaeling and
lukasmittag
|
I have created a new pull request with a single signed commit including all my changes. Here is the link to my new pull request #97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this feature "otel" enabled, it conditionally compiles the opentelemetry and the related tracing functionalities.