Add kuksa val v2 protocol #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wba2hi
force-pushed
the
add-kuksa-val-v2-protocol
branch
from
2b126c6 to
e4ea538
Compare
Chrylo
approved these changes
Jan 14, 2025
...a-sdk/src/main/kotlin/org/eclipse/kuksa/connectivity/databroker/v2/DataBrokerConnectionV2.kt
Show resolved
Hide resolved
|
LGTM
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Takes care of most of the stuff related to kuksa.val.v2 however no major breaking changes where introduced (e.g. converting coroutines to futures). Also it's mainly a lazily side-by-side implementation without common interfaces.
However I still think it's better to directly add this stuff here, than first inside vehicle-app-java-sdk.
Some polish needs to be done, to make sure everything is aligned / having common classes and stuff like this later on.
Missing stuff: