Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set target feature version to default if it is already set #1657

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

kysmith-csg
Copy link
Contributor

Previously, editing a target feature location would always set the version to 1.0.0.qualifier, even if the version was set already. This is because this initialize() method is called after the feature details are filled in.

Now, editing an existing feature will fill in the details as shown in the target file. New features will continue to be set to 1.0.0.qualifier.

Copy link

github-actions bot commented Jan 23, 2024

Test Results

  214 files  ±0    214 suites  ±0   21m 11s ⏱️ + 4m 0s
  664 tests ±0    654 ✅ +1  10 💤 ±0  0 ❌  - 1 
1 328 runs  ±0  1 306 ✅ +1  22 💤 ±0  0 ❌  - 1 

Results for commit 839548c. ± Comparison against base commit 60e66ff.

♻️ This comment has been updated with latest results.

Copy link
Member

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable

@laeubi
Copy link
Member

laeubi commented Jan 24, 2024

@kysmith-csg you need to bump the version of the affected bundle.

@kysmith-csg
Copy link
Contributor Author

@kysmith-csg you need to bump the version of the affected bundle.

Done, sorry about that.

@HannesWell
Copy link
Contributor

@kysmith-csg is this not relevant anymore?

@kysmith-csg kysmith-csg reopened this Feb 3, 2024
@kysmith-csg
Copy link
Contributor Author

@HannesWell it is still valid. I went to Github to update my fork and I completely forgot this pull request was open still. Luckily I still had the commit locally :)

Copy link
Contributor

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HannesWell it is still valid. I went to Github to update my fork and I completely forgot this pull request was open still. Luckily I still had the commit locally :)

No problem, I think that's the reason why it is recommended to use topic-branches for PRs 😅
But in order to prevent further disturbance lets submit this, it looks good.
Thanks for this contribution.

@HannesWell HannesWell merged commit d4d77aa into eclipse-m2e:master Feb 3, 2024
11 checks passed
@HannesWell HannesWell added this to the 2.6.0 milestone Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants