-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set target feature version to default if it is already set #1657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks reasonable
@kysmith-csg you need to bump the version of the affected bundle. |
Done, sorry about that. |
@kysmith-csg is this not relevant anymore? |
@HannesWell it is still valid. I went to Github to update my fork and I completely forgot this pull request was open still. Luckily I still had the commit locally :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HannesWell it is still valid. I went to Github to update my fork and I completely forgot this pull request was open still. Luckily I still had the commit locally :)
No problem, I think that's the reason why it is recommended to use topic-branches for PRs 😅
But in order to prevent further disturbance lets submit this, it looks good.
Thanks for this contribution.
Previously, editing a target feature location would always set the version to
1.0.0.qualifier
, even if the version was set already. This is because thisinitialize()
method is called after the feature details are filled in.Now, editing an existing feature will fill in the details as shown in the target file. New features will continue to be set to
1.0.0.qualifier
.