Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1575] EmptyStackException with javadoc on record method #1598

Merged
merged 1 commit into from
Jan 31, 2025
Merged

[#1575] EmptyStackException with javadoc on record method #1598

merged 1 commit into from
Jan 31, 2025

Conversation

ruspl-afed
Copy link
Contributor

  • support record types

Fixes #1575

@github-actions GitHub Actions
Copy link

Test Results

   285 files  ± 0     285 suites  ±0   48m 58s ⏱️ + 2m 40s
 3 608 tests +22   3 532 ✅ +22   76 💤 ±0  0 ❌ ±0 
11 016 runs  +66  10 785 ✅ +66  231 💤 ±0  0 ❌ ±0 

Results for commit 0fd77f2. ± Comparison against base commit 2413246.

@ruspl-afed
Copy link
Contributor Author

do you think we can merge this @HannesWell ?

laeubi
laeubi approved these changes Jan 31, 2025
View reviewed changes
Copy link
Contributor

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@laeubi laeubi merged commit 5c22fae into eclipse-pde:master Jan 31, 2025
18 checks passed
@ruspl-afed ruspl-afed deleted the 1575 branch January 31, 2025 19:30
@ruspl-afed
Copy link
Contributor Author

Thank you so much @laeubi !

@ruspl-afed ruspl-afed mentioned this pull request Feb 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laeubi laeubi laeubi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API-tools: EmptyStackException with javadoc on record method
2 participants
@ruspl-afed @laeubi